Simplify fetch() and fetch_items() in the backends
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchrombie
force-pushed
the
527-simply-fetch-and-fetch_items
branch
5 times, most recently
from
603f1ab to
f9e99f1
Compare
The default category is now set to the first category listed in the backend's `CATEGORIES` list. This change is necessary to accommodate the removal of backend-specific `fetch` methods, which previously handled category assignment. Updated the tests to validate the default and specific category assignments, and removed the obsolete `test_fetch_archive_needs_category`. Signed-off-by: Venu Vardhan Reddy Tekula <vt2182@nyu.edu>
vchrombie
force-pushed
the
527-simply-fetch-and-fetch_items
branch
from
f9e99f1 to
529c9ab
Compare
|
I saw two weeks ago some code to change this problem but I don't see it now. Any issues with it? Is there any way I can help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #527
I trying an attempt to solve this issue. I picked the Gitter backend to get started and see get some feedback on the changes. I will be working on rest of the backends one by one. I am sure this is going to be a huge PR, so I will take some time and add a backend each time allowing time for reviewing.
Let me know if you have any suggestions.