Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outdated] godot-git #2015

Closed
1 task
nyabinary opened this issue Oct 9, 2022 · 10 comments
Closed
1 task

[Outdated] godot-git #2015

nyabinary opened this issue Oct 9, 2022 · 10 comments
Labels
bug:PKGBUILD Something is wrong in the AUR side. priority:low This package affects just a few users. request:rebuild-pkg Package is missing a rebuild.

Comments

@nyabinary
Copy link

If available, link to the latest build

https://builds.garudalinux.org/repos/chaotic-aur/logs/godot-git.log

Package name

godot-git

Latest build

4.0.r47426.67961d875d51-1

Latest version available

master

Have you tested if the package builds in a clean chroot?

  • Yes

More information

PKGBuild got updated: https://aur.archlinux.org/packages/godot-git (+ fixed versioning in the update)

@nyabinary nyabinary added the request:rebuild-pkg Package is missing a rebuild. label Oct 9, 2022
Technetium1 added a commit to chaotic-aur/interfere that referenced this issue Oct 9, 2022
@Technetium1
Copy link
Member

Build is still failing the same way 😕

@Technetium1 Technetium1 added the priority:low This package affects just a few users. label Oct 9, 2022
@nyabinary
Copy link
Author

@Technetium1 what's the error?

@Technetium1
Copy link
Member

@VexfulNiko godot-git.log

==> Starting build()...
scons: Reading SConscript files ...

scons: *** Invalid value for option target: release_debug.  Valid values are: ('editor', 'template_release', 'template_debug')
File "/home/main-builder/pkgwork/src/godot/SConstruct", line 249, in <module>
==> ERROR: A failure occurred in build().

@nyabinary
Copy link
Author

@Technetium1 could this be fixed with a interference? It seems to be a simple value change.

@nyabinary
Copy link
Author

nyabinary commented Oct 10, 2022

@Technetium1 godotengine/godot#66242 this is the breaking commit/pr. It simplifies the options.
Note: Unlike previously, dev_build defaults to off so that users who
compile Godot from source get an optimized and small build by default.
Engine contributors should now set dev_build=yes in their build scripts or
IDE configuration manually.

@Technetium1 Technetium1 added waiting:upstream-fix Waiting for fix in AUR or in the project iself. bug:PKGBUILD Something is wrong in the AUR side. labels Oct 11, 2022
@dr460nf1r3
Copy link
Member

We could technically sed the PKGBUILD, however it would be preferable to have it fixed on the AUR side as everyone benefits by this. So yeah, waiting for upstream fix it is 😋

@nyabinary
Copy link
Author

nyabinary commented Oct 11, 2022

Godot.tar.gz
@dr460nf1r3 I created a pkgbuild that contains a fix. Here is the pkg with icons, and everything is ready to go, compiled it on my system, and it worked! Godot updates a lot, so I think it should be put to build and compile hourly.

@nyabinary
Copy link
Author

@dr460nf1r3 Maybe this can be a separate repo as well, so I can fix it in any updates upstream that requires changing the build process.

@dr460nf1r3
Copy link
Member

Well, lets see how it goes. Feel free to submit a PR containing the PKGBUILD here: https://github.com/chaotic-aur/pkgbuild-godot-git

@nyabinary
Copy link
Author

@dr460nf1r3 I added the PKGBUILD(s). Thank you :)

@Technetium1 Technetium1 removed the waiting:upstream-fix Waiting for fix in AUR or in the project iself. label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:PKGBUILD Something is wrong in the AUR side. priority:low This package affects just a few users. request:rebuild-pkg Package is missing a rebuild.
Development

No branches or pull requests

3 participants