test(prettier): add scripts/prettier-test.sh #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here test failed because @char0n : what do you think ? |
|
It'd be better if it only check files that differ from |
|
I think CI should never fail on master, so a PR isn't a good PR if build fails. |
move prettier from `lint` to `lint:fix` npm script, run `prettier-test.sh` in `lint` Ref #379
guillaumearm
force-pushed
the
prettier-test
branch
from
65243a9 to
e7d812c
Compare
|
To simplify things, we could run Prettier from within Eslint, one step less to worry about: https://prettier.io/docs/en/eslint.html |
wojpawlik
reviewed
Feb 19, 2018
| @@ -62,7 +62,8 @@ | |||
| }, | |||
| "betterScripts": { | |||
| "docs": "jsdoc -c jsdoc.json && node ./scripts/jsdoc-inject-dist.js", | |||
| "lint": "prettier test/**.js src/**.js --write && eslint ./ && tslint -c tslint.json src/index.d.ts", | |||
| "lint": "./scripts/prettier-test.sh && eslint ./ && tslint -c tslint.json src/index.d.ts", | |||
| "lint:fix": "prettier test/**.js src/**.js --write", | |||
There was a problem hiding this comment.
lint:fix should probably also run eslint --fix after prettier... Either directly, or by using prettier-eslint
|
Closing until #387 is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linttolint:fixnpm scriptprettier-test.shinlintnpm scriptRef #379, #336