-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoding and mailbox attrs #35
base: master
Are you sure you want to change the base?
Conversation
EDIT: this has grown of its own to handle all special cases i kept seeing. This may not be good to merge now. The choice is yours. |
self.to = self.message['to'] | ||
self.fr = self.message['from'] | ||
self.delivered_to = self.message['delivered_to'] | ||
def to_unicode(value, charset): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why duplicate make a duplicate function that just calls try_parse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proboaby some leftover from previous code. Nicely spotted, removing that!
This is a "small" yet useful PR, with several features:
custom_query
parameterfrom
andto
headers (quoted printable content)body
andtext
from mail_encoding to unicodeSorry, should have broken this into several smaller PR.