Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign #22

Merged
merged 20 commits into from
Dec 11, 2012
Merged

Redesign #22

merged 20 commits into from
Dec 11, 2012

Conversation

rstacruz
Copy link
Collaborator

See #6.

image

@rstacruz rstacruz mentioned this pull request Dec 10, 2012
Closed
@haileys
Copy link
Collaborator

haileys commented Dec 11, 2012

Holy crap that's beautiful!

I'll play around with it tonight and merge it in. Thanks so much for all the time and effort you've put in to this.

@ndbroadbent
Copy link
Contributor

@rstacruz, you are awesome! This is amazing! 👍

@rstacruz
Copy link
Collaborator Author

Would you be interested in code-highlighted var dumps?

image

@haileys
Copy link
Collaborator

haileys commented Dec 11, 2012

What's the performance impact like?

On Tuesday, 11 December 2012 at 4:09 PM, Rico Sta. Cruz wrote:

Would you be interested in code-highlighted var dumps?

—
Reply to this email directly or view it on GitHub (#22 (comment)).

@rstacruz
Copy link
Collaborator Author

Haven't taken scientific measurements, but it feels okay on my computer

@haileys
Copy link
Collaborator

haileys commented Dec 11, 2012

Perhaps leave it out for the time being and we can add it back in after the new design is merged

@rstacruz
Copy link
Collaborator Author

Agree.

@rstacruz
Responsive redesign of the error page. (BetterErrors#6)
5206c32
@rstacruz
make the exception message more prominent
ecb0e7e
@rstacruz
firefox compatibility, and simplify the design a bit
6790988
@rstacruz
update colors
715634f
@rstacruz
fix repl line being too narrow
574ccc2
@rstacruz
highlight the stack trace method names differently
2160814
@rstacruz
update image in readme
0213587
@rstacruz
remove superfluous extra line on repl
81c41d4
@rstacruz
prevent horizontal scrollbars in firefox in the repl shell
ad450c6
@rstacruz
fix floatdropping on stack trace names in single-column mode
7daf8ff
@rstacruz
make layout more responsive by not clipping the header text in skinny…
d441a47 
… mode
@rstacruz
show only application frames by default
61a91d0
@rstacruz
go for a slightly flatter look
68b5862
@rstacruz
show filename more prominently in frame info
b4c2a7c
@rstacruz
highlight offending line on load
eb14017
@rstacruz
style the 'source unavailable' message
4e50dd7
@rstacruz
memoize the name-splitting regex
abea3b5
@rstacruz
show full exception message on hover; truncate message to 5 lines
e01dc40 
This is great for HAML error messages, which are unnaturally large, like
80 lines.
@rstacruz
remove annoying extra white line in 1-column mode
9b9b7e8
@rstacruz
limix max-height of long vardumps, and prevent superwide vardumps
69a327c
@haileys
Copy link
Collaborator

haileys commented Dec 11, 2012

I've noticed some issues with the custom scrollbar - I'm going to remove the code responsible for that and fall back to the system scroll bar

edit: fixed

@haileys haileys merged commit 69a327c into BetterErrors:master Dec 11, 2012
@rolfb
Copy link

rolfb commented Jun 24, 2013

This is the most awesome pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rstacruz @haileys @ndbroadbent @rolfb