Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended Coordinates mouse reporting & additional buttons support #594

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Extended Coordinates mouse reporting & additional buttons support #594

merged 4 commits into from
Dec 4, 2023

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Nov 10, 2022 •
edited
Loading

The X10 mouse protocol limits the X and Y coordinates to 223. This adds SGR (1006) mode to enable extended mouse events support.

  • Add shift modifier support
  • Support left/right wheel buttons (codes 6 & 7)
  • Support additional mouse button (codes 8-11)
  • Report which button was released (SGR feature)

Wants: muesli/termenv#104

Fixes: #359
Fixes: #718

@aymanbagabas aymanbagabas marked this pull request as draft November 10, 2022 17:17
@aymanbagabas aymanbagabas force-pushed the ext-mouse branch 4 times, most recently from decd02a to 1e450d4 Compare November 14, 2022 23:54
@aymanbagabas aymanbagabas changed the title Extended Coordinates mouse support Extended Coordinates mouse parse support Nov 15, 2022
meowgorithm
meowgorithm reviewed Nov 15, 2022
View reviewed changes
examples/mouse/main.go Outdated Show resolved Hide resolved
meowgorithm
meowgorithm reviewed Nov 15, 2022
View reviewed changes
mouse.go Show resolved Hide resolved
meowgorithm
meowgorithm reviewed Nov 15, 2022
View reviewed changes
mouse.go Outdated Show resolved Hide resolved
@aymanbagabas aymanbagabas marked this pull request as ready for review January 25, 2023 20:37
@aymanbagabas aymanbagabas changed the title Extended Coordinates mouse parse support Extended Coordinates mouse reporting & additional buttons support Jan 25, 2023
@aymanbagabas aymanbagabas force-pushed the ext-mouse branch 6 times, most recently from 7e61d16 to 675334f Compare January 25, 2023 20:55
@aymanbagabas aymanbagabas force-pushed the ext-mouse branch 2 times, most recently from 47fdcdd to d9270ed Compare February 21, 2023 17:49
@kylezb kylezb mentioned this pull request Apr 11, 2023
Closed
@BigJk BigJk mentioned this pull request Apr 11, 2023
Closed
@DerpyDashie DerpyDashie mentioned this pull request May 24, 2023
Closed
@aymanbagabas aymanbagabas force-pushed the ext-mouse branch 2 times, most recently from 6e316e7 to eb8ced3 Compare October 4, 2023 16:56
@aymanbagabas aymanbagabas force-pushed the ext-mouse branch 2 times, most recently from 7fa30ef to 5b0862c Compare October 4, 2023 16:58
@aymanbagabas
feat(mouse): add extended mouse & shift key support
19d760d 
Support SGR(1006) mouse mode
Support parsing shift key press
Support additional mouse buttons
Report which button was released
Report button motion
robin-samuel
robin-samuel suggested changes Oct 12, 2023
View reviewed changes
key.go Outdated Show resolved Hide resolved
@robin-samuel robin-samuel mentioned this pull request Oct 12, 2023
Merged
@aymanbagabas aymanbagabas merged commit a154847 into master Dec 4, 2023
18 checks passed
@aymanbagabas aymanbagabas deleted the ext-mouse branch December 4, 2023 16:51
aymanbagabas added a commit that referenced this pull request Mar 1, 2024
@aymanbagabas
fix(typo): initial variable during input parsing
aaf740e 
This was probably a typo since the `w` gets set again during
`detectOneMsg` it wouldn't make sense to initially set it to `07` and it
makes the code confusing.

Fixes: a154847 (feat: extended Coordinates mouse reporting & additional buttons support (#594))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-samuel robin-samuel robin-samuel requested changes

@meowgorithm meowgorithm meowgorithm approved these changes

@muesli muesli Awaiting requested review from muesli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aymanbagabas @meowgorithm @robin-samuel