Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove sqlite metrics #137

Merged
merged 3 commits into from
May 5, 2022
Merged

feat: remove sqlite metrics #137

merged 3 commits into from
May 5, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented May 5, 2022

They are not really useful anyway, and prometheus works great.

Remove sqlite metrics backend in favor of prometheus impl.

refs #135

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this May 5, 2022
@caarlos0 caarlos0 requested a review from aymanbagabas May 5, 2022 00:24
@caarlos0 caarlos0 added the enhancement New feature or request label May 5, 2022
@caarlos0 caarlos0 marked this pull request as ready for review May 5, 2022 00:24
@aymanbagabas aymanbagabas requested a review from toby May 5, 2022 00:30
server/server.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 requested a review from aymanbagabas May 5, 2022 01:04
server/server.go Outdated Show resolved Hide resolved
server/server.go Outdated Show resolved Hide resolved
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 requested a review from aymanbagabas May 5, 2022 01:55
@caarlos0 caarlos0 merged commit 3b64fbd into main May 5, 2022
@caarlos0 caarlos0 deleted the rm-sqlite-metrics branch May 5, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants