Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix string literal parsing for delimiter #30

Merged
merged 2 commits into from
Apr 13, 2022
Merged

fix: fix string literal parsing for delimiter #30

merged 2 commits into from
Apr 13, 2022

Conversation

bashbunni
Copy link
Member

@bashbunni bashbunni commented Mar 31, 2022 •
edited
Loading

Changes Made:

  • use strconv.Decode to force string to get interpreted

Questions

Line 171 - how should we handle the error?

About the Issue

First two outputs reflect the new changes, while the latter two show the issue.
image

@bashbunni
Copy link
Member Author

Update:

  • wrap error and return if decode fails
  • make this string concatenation instead of Sprintf

@toby toby merged commit 659a130 into main Apr 13, 2022
@toby toby deleted the string-parsing branch April 13, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bashbunni @toby