Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test framework supports turning off -race flag #605

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jaw
Copy link
Contributor

@jaw jaw commented Nov 21, 2024

This is useful on Windows where gcc is not always
available.

@jaw jaw requested a review from aymanbagabas as a code owner November 21, 2024 09:19
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.64%. Comparing base (b06b555) to head (880c011).
Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   51.96%   51.64%   -0.32%     
==========================================
  Files         157      159       +2     
  Lines       13454    13545      +91     
==========================================
+ Hits         6991     6995       +4     
- Misses       5891     5977      +86     
- Partials      572      573       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment 🙂

EDIT: Where is this being used? It seems like it needs to go into the coverage and build workflows

testscript/script_test.go Outdated Show resolved Hide resolved
@aymanbagabas
Copy link
Member

@jaw Could you please rebase onto main to fix the CI?

This is useful on Windows where gcc is not always
available.
@jaw
Copy link
Contributor Author

jaw commented Dec 6, 2024

@aymanbagabas thanks for fixing the race cond! Rebased...

@aymanbagabas aymanbagabas merged commit 0540b4d into charmbracelet:main Dec 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants