fix: test framework supports ensuring specific port is open #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic "waitforserver" has been renamed to "ensureserverrunning". This command now also takes an argument which denotes which environment variable to pick the port from. This is needed as the ports are randomized by the test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 51.96% 51.67% -0.29%
==========================================
Files 157 159 +2
Lines 13454 13529 +75
==========================================
Hits 6991 6991
- Misses 5891 5969 +78
+ Partials 572 569 -3 ☔ View full report in Codecov by Sentry. |
aymanbagabas
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic "waitforserver" has been renamed to
"ensureserverrunning".
This command now also takes an argument which denotes which environment variable to pick the port from.
This is needed as the ports are randomized by the test.