fix: prevent enumeration of private repo

[kyokugirl]

This PR fixes the issue by:

• making checkIfReadable to return RepoNotFound instead of Unauthorized
• changing all commands that works on a repo to run checkIfReadable before performing anything
• updating tests to reflect the changes

Closes #595

[kyokugirl]

It doesn't look like that the CI failure is caused because of the changes of this PR.... Can someone look into this?

[aymanbagabas]

It doesn't look like that the CI failure is caused because of the changes of this PR.... Can someone look into this?

You're right, the CI fails because of changes not related to this PR 🙂

[aymanbagabas]

@kyokugirl Could you please rebase onto main?

[kyokugirl]

@aymanbagabas Done ✅

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.72%. Comparing base (b06b555) to head (f2f2219).
Report is 94 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/ssh/cmd/cmd.go	66.66%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   51.96%   51.72%   -0.24%     
==========================================
  Files         157      159       +2     
  Lines       13454    13557     +103     
==========================================
+ Hits         6991     7012      +21     
- Misses       5891     5973      +82     
  Partials      572      572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aymanbagabas]

Thank you @kyokugirl!