Upgrade to React and React DOM 18 #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcasey
commented
Jan 3, 2023
| @@ -173,7 +173,8 @@ export default function GuildsAutocomplete({ | |||
| placeholder='Type Guild name...' | |||
| /> | |||
| )} | |||
| renderOption={(props, guildName) => [props, guildRecord[guildName]]} | |||
| // used to be: => [props, guildRecord[guildName]] | |||
| renderOption={(props, guildName) => <span>{guildName}</span>} | |||
There was a problem hiding this comment.
TODO: make sure this still works
mattcasey
added
🚀 deploy
msadura
approved these changes
Jan 10, 2023
* upgrade next to 13 * fix tsc * . * fix react roots * investigate charm editor * fix editor * fix public pages * . * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am also updating any packages that expected React 17:
fullcalendar
react-clipboard-to-copy
next.js
mui
@emotion
Fixed flickering between states by removing a listener inside of RouteGuard that was re-mounting the page on navigation
Fixed CharmEditor by wrapping node view updates with 'flushSync()'. There was a similar issue in Tiptap
fix: fix React Node View render problem in React 18 fix: fix React Node View render problem in React 18 ueberdosis/tiptap#2985