Skip to content

Commit

Permalink
Package.json for v.2.2.0-rc.1 and fixed travis deploy
Browse files Browse the repository at this point in the history
  • Loading branch information
etimberg committed Jul 14, 2016
1 parent bfa37e7 commit 5804f1e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ deploy:
- "./dist/Chart.bundle.min.js"
- "./dist/Chart.js"
- "./dist/Chart.min.js"
- "./dist/Chart.js.zip"

This comment has been minimized.

Copy link
@simonbrunel

simonbrunel Jul 15, 2016

Member

My bad, the issue is not here but in the gulp.js file: the line that creates this file is commented, not sure why, certainly testing. Anyway, the npm release would have fail because you need to change the package.json version BEFORE creating the git tag (see #2555 for the full process). And we really need that file because it contains all dist files + the samples.

This comment has been minimized.

Copy link
@etimberg

etimberg Jul 15, 2016

Author Member

Ah, ok. Do you want me to update this or do you want to open a PR?

This comment has been minimized.

Copy link
@simonbrunel

simonbrunel Jul 15, 2016

Member

I fixed it directly in master, do you mind if I republish the 2.2.0-rc.1 release?

This comment has been minimized.

Copy link
@etimberg

etimberg Jul 15, 2016

Author Member

sure, try it. or feel free to do a 2.2.0-rc.2

skip_cleanup: true
on:
tags: true
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "chart.js",
"homepage": "http://www.chartjs.org",
"description": "Simple HTML5 charts using the canvas element.",
"version": "2.1.6",
"version": "2.2.0-rc.1",
"license": "MIT",
"main": "src/chart.js",
"repository": {
Expand Down

0 comments on commit 5804f1e

Please sign in to comment.