Skip to content

Commit

Permalink
Remove plugin fallback to root options/defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
kurkle committed Feb 13, 2021
1 parent 2d7e0cc commit 6179f44
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 0 additions & 2 deletions docs/docs/general/options.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,9 @@ Each scope is looked up with `elementType` prefix in the option name first, then
* options.plugins[`plugin.id`]
* options.controllers[`config.type`].plugins[`plugin.id`]
* (options.[`...plugin.additionalOptionScopes`])
* options
* defaults.controllers[`config.type`].plugins[`plugin.id`]
* defaults.plugins[`plugin.id`]
* (defaults.[`...plugin.additionalOptionScopes`])
* defaults

## Scriptable Options

Expand Down
3 changes: 1 addition & 2 deletions src/core/core.plugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,7 @@ function pluginOpts(config, plugin, opts, context) {
const keys = [
`controllers.${config.type}.plugins.${id}`,
`plugins.${id}`,
...plugin.additionalOptionScopes || [],
''
...plugin.additionalOptionScopes || []
];
const scopes = config.getOptionScopes(opts || {}, keys);
return config.createResolver(scopes, context);
Expand Down

0 comments on commit 6179f44

Please sign in to comment.