Fix memory leak on destroy (#8438)

chartjs · Feb 16, 2021 · a6a1228 · a6a1228
1 parent b77f258
commit a6a1228
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/core/core.config.js b/src/core/core.config.js
@@ -156,9 +156,13 @@ export default class Config {
 
   update(options) {
     const config = this._config;
+    this.clearCache();
+    config.options = initOptions(config, options);
+  }
+
+  clearCache() {
     this._scopeCache.clear();
     this._resolverCache.clear();
-    config.options = initOptions(config, options);
   }
 
   /**

diff --git a/src/core/core.controller.js b/src/core/core.controller.js
@@ -831,6 +831,8 @@ class Chart {
       me._destroyDatasetMeta(i);
     }
 
+    me.config.clearCache();
+
     if (canvas) {
       me.unbindEvents();
       clearCanvas(canvas, ctx);