Options need to include dataset level defaults from main chart type (#…

…8534)
chartjs · Feb 28, 2021 · c040b82 · c040b82
1 parent d08eb14
commit c040b82
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/core/core.config.js b/src/core/core.config.js
@@ -276,9 +276,11 @@ export default class Config {
    * @return {object[]}
    */
   chartOptionScopes() {
+    const controllerDefaults = defaults.controllers[this.type] || {};
     return [
       this.options,
-      defaults.controllers[this.type] || {},
+      controllerDefaults,
+      controllerDefaults.datasets || {},
       {type: this.type},
       defaults,
       defaults.descriptors

diff --git a/test/specs/core.controller.tests.js b/test/specs/core.controller.tests.js
@@ -171,6 +171,17 @@ describe('Chart', function() {
       defaults.controllers.line.spanGaps = false;
     });
 
+    it('should initialize config with default dataset options', function() {
+      var defaults = Chart.defaults.controllers.pie.datasets;
+
+      var chart = acquireChart({
+        type: 'pie'
+      });
+
+      var options = chart.options;
+      expect(options.circumference).toBe(defaults.circumference);
+    });
+
     it('should override axis positions that are incorrect', function() {
       var chart = acquireChart({
         type: 'line',