fix: correct typing for doughnut, pie, and polarArea charts #11521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
changed the title
kurkle
approved these changes
Nov 18, 2024
etimberg
approved these changes
Nov 18, 2024
|
Holy cow! That's quite the lead time on getting this merged :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #10896
This is a change to
DoughnutAnimationOptionsto base the interface off ofAnimationSpec<"doughnut">.This appears to be the correct choice as a few of the existing tests include animation options in various doughnut based charts and include properties such as
delayandeasingwhich are missing fromDoughnutAnimationOptionsbut are present in theAnimationSpecinterface.Also includes a basic test that ensures that
DoughnutAnimationOptionsis fully assignable toChartOptions<"doughnut">