-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis GitHub Releases #2550
Travis GitHub Releases #2550
Conversation
Travis now builds and deploys these files for all tags, so we don't need to have them on the repository anymore.
I think we should keep the dist files in the repo. When people come here from the website for the first time they probably click the download button, without checking for a release first (at least that's what I did a while ago when I started using Chart.js). (Plus doesn't this make private keys available to everyone in travis.yml?) Either way will be fine I'm sure, just my 2¢ Edit: After some more research, this probably is a better and cleaner system, I think it would be good |
Very cool man! |
@zachpanz88 the token is encrypted from the actual token. The alternate is that we add it as a environment variable in travis. I don't know which is better @simonbrunel |
The whole thing here is to remove dist files from the repo, it doesn't make sense to have them here:
For first time users, we should had a "download" link (readme.md and website?) to the releases page. I encrypted the token with the Travis command line, meaning it uses a public key for encryption, decryption can only be done with a private key owned by Travis (if I understood correctly). So I would have no worries about the API key. |
Sounds good to me. I do think that we should add a link on the website to the downloads page in addition. |
Just found this link: https://github.com/chartjs/Chart.js/releases/latest We could use it in the website, README.md and the documentation. |
PR incidentally merged (sorry for that), master has been reset to the correct commit. I created this new PR #2552. |
Update
.travis.yml
to build and uploaddist/*
files when a tag is created, then removedist/*
files from the repository. The new release process would be:dist/*
files are uploaded along the release (automatic)We will also need to update CDNjs to use these uploaded files.
Proof of concept: https://github.com/chartjs/chartjs-color/releases/tag/2.0.0