Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extend and inherits helpers in helpers.core.js #4878

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

simonbrunel
Copy link
Member

@simonbrunel simonbrunel commented Oct 21, 2017

Fix Rollup issue caused by early access of the extend and inherits helpers not yet part of the helpers/index import. Also added (basic) unit tests for those methods.

Relates to #4478
Fixes #4746

Fix Rollup issue caused by early access of the `extend` and `inherits` helpers not yet part of the `helpers/index` import. Also added (basic) unit tests for whose methods.
@simonbrunel
Copy link
Member Author

@roman-17 @imranmomin @quiringk @iquiw could you guys checkout this PR and check if it fixes the rollup issue you reported?

@benmccann benmccann mentioned this pull request Oct 21, 2017
4 tasks
@iquiw
Copy link

iquiw commented Oct 22, 2017

It's works for me. Thank you.

@benmccann
Copy link
Contributor

@etimberg any reason you didn't merge this one?

@simonbrunel
Copy link
Member Author

Yes, I would like to wait a bit for feedback from @roman-17, who reported this issue.

@roman-17
Copy link

@simonbrunel sorry for late response - yes, it works like a charm :)

@imranmomin
Copy link

works great.. no issues.

@simonbrunel simonbrunel merged commit 26c1936 into chartjs:master Oct 24, 2017
@simonbrunel simonbrunel deleted the fix/rollup branch October 24, 2017 17:11
yofreke pushed a commit to yofreke/Chart.js that referenced this pull request Dec 30, 2017
Fix Rollup issue caused by early access of the `extend` and `inherits` helpers not yet part of the `helpers/index` import. Also added (basic) unit tests for whose methods.
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Fix Rollup issue caused by early access of the `extend` and `inherits` helpers not yet part of the `helpers/index` import. Also added (basic) unit tests for whose methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants