Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Chart.controllers.* importable #5871

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

simonbrunel
Copy link
Member

@simonbrunel simonbrunel commented Nov 29, 2018

controllers.*.js and core.datasetController.js are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for bar/horizontalBar and doughnut/pie in separate files, added a global controllers import (src/controllers/index.js) and add tests to check that all dataset controllers are correctly registered under chart.controllers.{type}.

Related to #4478

`controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controllers import (`src/controllers/index.js`) and add tests to check that all dataset controllers are correctly registered under `chart.controllers.{type}`.
@simonbrunel simonbrunel added this to the Version 2.8 milestone Nov 29, 2018
@simonbrunel simonbrunel merged commit be8d78a into chartjs:master Nov 29, 2018
@simonbrunel simonbrunel deleted the chore/modules-controllers branch November 29, 2018 20:06
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
`controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controllers import (`src/controllers/index.js`) and add tests to check that all dataset controllers are correctly registered under `chart.controllers.{type}`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants