Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arc size calculation when circumference is under 2PI #6224

Merged
merged 2 commits into from
May 1, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Apr 25, 2019

In doughnut and pie charts, an arc border is cut off when the circumference is under 2*PI. This PR fixes it.

Master: https://jsfiddle.net/nagix/cbma01yp/
Screen Shot 2019-04-25 at 5 17 20 PM

This PR: https://jsfiddle.net/nagix/7cxub8qf/
Screen Shot 2019-04-25 at 5 18 24 PM

kurkle
kurkle previously approved these changes Apr 25, 2019
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

etimberg
etimberg previously approved these changes Apr 25, 2019
benmccann
benmccann previously approved these changes Apr 26, 2019
@simonbrunel simonbrunel added this to the Version 2.9 milestone Apr 26, 2019
@nagix nagix dismissed stale reviews from benmccann, etimberg, and kurkle via 799d0bb May 1, 2019 08:09
@nagix
Copy link
Contributor Author

nagix commented May 1, 2019

Refactoring is done. This saves 351 bytes.

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nagix, it's way more readable now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants