-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat null as NaN in radialLinear scale #6282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
previously approved these changes
May 17, 2019
I realized it's ok to directly return |
etimberg
previously approved these changes
May 17, 2019
kurkle
previously approved these changes
May 17, 2019
benmccann
previously approved these changes
May 18, 2019
Rebased and updated image tests based on #6281. |
simonbrunel
approved these changes
May 21, 2019
Thanks @nagix |
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
null
value is treated as the minimum value on a radialLinear scale. To be consistent with other scales,null
should be treated asNaN
.Master: https://jsfiddle.net/nagix/vskjcz41/
This PR: https://jsfiddle.net/nagix/g6x7Lt91/