Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] FitBoxes recursion when dimensions are NaN #7853

Merged
merged 2 commits into from
Oct 9, 2020
Merged

[2.9] FitBoxes recursion when dimensions are NaN #7853

merged 2 commits into from
Oct 9, 2020

Conversation

alessandroasm
Copy link

Adding a verification on updateDims that handles a case when dimensions are both NaN. This caused an infinite recursion on fitBoxes when calculating the layout for a chart that is mounted on an element that is not yet in DOM.

I also added a test case for this issue.

Fixes #7761

@kurkle
Copy link
Member

kurkle commented Oct 6, 2020

Looks like gulp docs is failing for some reason.

@etimberg
Copy link
Member

etimberg commented Oct 6, 2020

Looks like gulp docs is failing for some reason.

npm run docs doesn't do npm ci inside of the docs folder, instead it does npm install. Likely a dependency updated.

@alessandroasm alessandroasm changed the title Fixboxes recursion when dimensions are NaN FitBoxes recursion when dimensions are NaN Oct 6, 2020
@kurkle
Copy link
Member

kurkle commented Oct 6, 2020

npm run docs doesn't do npm ci inside of the docs folder, instead it does npm install. Likely a dependency updated.

This is against 2.9, so it uses gitbook. It looks like the issue is in that.

@kurkle
Copy link
Member

kurkle commented Oct 6, 2020

GitbookIO/gitbook-cli#110

This was referenced Oct 7, 2020
Closed
Closed
@kurkle kurkle changed the title FitBoxes recursion when dimensions are NaN [2.9] FitBoxes recursion when dimensions are NaN Oct 8, 2020
@alessandroasm
Infinite recursion when dimensions are NaN
dce2063 
Adding a verification on updateDims that handles a case when dimensions are both
NaN. This caused an infinite recursion on fitBoxes when calculating the layout
for a chart that is mounted on an element that is not yet in DOM.

Fixes chartjs#7761
@alessandroasm
Fixing lint errors
ef43b7f
@alessandroasm alessandroasm force-pushed the fixboxes-recursion-when-dimensions-are-nan branch from c7052a7 to ef43b7f Compare October 8, 2020 13:22
@etimberg etimberg merged commit 063b7dc into chartjs:2.9 Oct 9, 2020
@etimberg etimberg linked an issue Oct 9, 2020 that may be closed by this pull request
"Uncaught RangeError: Maximum call stack size exceeded" when parent element not in DOM tree yet #7761
Closed
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 12, 2021
Open
@martinakraus martinakraus mentioned this pull request Jun 5, 2024
Closed
@jaimeperez-vs jaimeperez-vs mentioned this pull request Jun 18, 2024
Open
This was referenced Aug 16, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
@ryanmichaelfabayos ryanmichaelfabayos mentioned this pull request Sep 20, 2024
Open
@luisgarciaxygeni luisgarciaxygeni mentioned this pull request Sep 28, 2024
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Uncaught RangeError: Maximum call stack size exceeded" when parent element not in DOM tree yet
3 participants
@alessandroasm @kurkle @etimberg