Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture for bar hide/show animation #8453

Merged
merged 3 commits into from
Feb 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/core.animations.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ defaults.set('animation', {
},
visible: {
type: 'boolean',
easing: 'easeInExpo' // for keeping the dataset visible almost all the way through the animation
fn: v => v < 1 ? 0 : 1 // for keeping the dataset visible all the way through the animation
},
}
});
Expand Down
84 changes: 84 additions & 0 deletions test/fixtures/controller.bar/bar-animation-hide-show.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
const canvas = document.createElement('canvas');
canvas.width = 512;
canvas.height = 512;
const ctx = canvas.getContext('2d');

module.exports = {
config: {
type: 'bar',
data: {
labels: [0],
datasets: [
{
data: [1],
backgroundColor: 'rgba(255,0,0,0.5)'
},
{
data: [2],
backgroundColor: 'rgba(0,0,255,0.5)'
},
{
data: [3],
backgroundColor: 'rgba(0,255,0,0.5)'
}
]
},
options: {
animation: {
duration: 14000,
easing: 'linear'
},
events: [],
scales: {
x: {display: false},
y: {display: false, max: 4}
}
}
},
options: {
canvas: {
height: 512,
width: 512
},
run: function(chart) {
const animator = Chart.animator;
const anims = animator._getAnims(chart);
// disable animator
const backup = animator._refresh;
animator._refresh = function() { };

return new Promise((resolve) => {
window.requestAnimationFrame(() => {
// make sure previous animation is finished
animator._update(Date.now() * 2);

chart.hide(1);
let start = anims.items[0]._start;
for (let i = 0; i < 8; i++) {
animator._update(start + i * 2000);
let x = i % 4 * 128;
let y = Math.floor(i / 4) * 128;
ctx.drawImage(chart.canvas, x, y, 128, 128);
}

// make sure previous animation is finished
animator._update(Date.now() * 2);

chart.show(1);
start = anims.items[0]._start;
for (let i = 0; i < 8; i++) {
animator._update(start + i * 2000);
let x = i % 4 * 128;
let y = Math.floor(2 + i / 4) * 128;
ctx.drawImage(chart.canvas, x, y, 128, 128);
}
Chart.helpers.clearCanvas(chart.canvas);
chart.ctx.drawImage(canvas, 0, 0);

animator._refresh = backup;
resolve();
});
});
}
}
};
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.