Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the constantly failing test #8538

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Remove the constantly failing test #8538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 0 additions & 47 deletions test/specs/core.animations.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,51 +172,4 @@ describe('Chart.animations', function() {
}, 250);
}, 50);
});

describe('default transitions', function() {
describe('hide', function() {
it('should keep dataset visible through the animation', function(done) {
let count = 0;
window.acquireChart({
type: 'line',
data: {
labels: [0],
datasets: [
{data: [1]},
]
},
options: {
animation: {
duration: 0,
onProgress: (args) => {
if (!args.chart.isDatasetVisible(0) && args.currentStep / args.numSteps < 0.9) {
// while animating, visible should be truthly
// sometimes its not, thats why we check only up to 90% of the animation
expect(args.chart.getDatasetMeta(0).visible).toBeTruthy();
count++;
}
},
onComplete: (args) => {
if (args.chart.isDatasetVisible(0)) {
args.chart.hide(0);
} else {
// and when finished, it should be false
expect(args.chart.getDatasetMeta(0).visible).toBeFalsy();
expect(count).toBeGreaterThan(0);
done();
}
}
},
transitions: {
hide: {
animation: {
duration: 100
}
}
}
}
});
});
});
});
});