Add exports to manage "import" and "require" inclusions #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeLenaleee
reviewed
Jan 9, 2023
LeeLenaleee
approved these changes
Jan 9, 2023
|
bug? version 2.1.2 or can it wait minor? |
|
if we go to 2.1.2 (in my opinion make sense), can we have a look to PR #826 in order to fix the doc as well? |
|
212 seems correct to me |
|
This PR appears to resolve #786 for me, as I've just described in a comment on that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #83. @kurkle @LeeLenaleee can you confirm? My experience on packaging is not so huge.