-
Notifications
You must be signed in to change notification settings - Fork 484
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix reading element values when display is 'auto'
Chart.js 3 removed el._model in favor of getProps(), making harder to abstract reading values in positioners. Also, using string arrays to read values (i.e. var {a,b,c} = el.getProps(["a","b","c"])) would make positioners inefficient in the normal case (i.e. not the final values) and the code a bit ugly, so let's use a Proxy instead.
- Loading branch information
1 parent
02adbb8
commit f0b8ca1
Showing
8 changed files
with
16 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
extends: chartjs | ||
|
||
parserOptions: | ||
ecmaVersion: 8 | ||
sourceType: module | ||
ecmaVersion: 2015 | ||
|
||
env: | ||
browser: true | ||
node: true | ||
es6: true |
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
plugins: [es] | ||
|
||
extends: [ | ||
plugin:es/restrict-to-es5 | ||
plugin:es/restrict-to-es2015 | ||
] | ||
|
||
rules: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,5 @@ | ||
env: | ||
jasmine: true | ||
es6: true | ||
parserOptions: | ||
ecmaVersion: 8 | ||
|
||
globals: | ||
__karma__: true | ||
|