Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused and incorrect plugin hook param #268

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Remove unused and incorrect plugin hook param #268

merged 1 commit into from
Aug 2, 2021

Conversation

LeeLenaleee
Copy link
Contributor

Resolves #266

@simonbrunel simonbrunel added the bug label Aug 2, 2021
@simonbrunel simonbrunel added this to the 2.1 milestone Aug 2, 2021
@simonbrunel simonbrunel changed the title remove unused and incorrect param Remove unused and incorrect plugin hook param Aug 2, 2021
simonbrunel
simonbrunel approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeeLenaleee

@simonbrunel simonbrunel merged commit cdc2e94 into chartjs:master Aug 2, 2021
@simonbrunel simonbrunel mentioned this pull request Aug 2, 2021
Closed
@LeeLenaleee LeeLenaleee deleted the fix/remove-unused-param branch September 27, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 2.1
Development

Successfully merging this pull request may close these issues.

afterUpdate missing args parameter/too many args passed to layout.prepare()
2 participants
@LeeLenaleee @simonbrunel