fix(extensions): change portable extensions dir #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Solves the issue shanalikhan#756 caused by a hardcoded extension dir.
This is a temporary workaround and we should use the env variables to check a valid extension dir instead of hardcoded ones:
Changes proposed in this pull request:
The
extensionDir
variable was changed to.vscode/
to prevent the sync of "something" with.vscode
in its name. (ex:bung87.vscode-gemfile
)code-settings-sync/src/service/pluginService.ts
Line 12 in 3646117
The
extensionDirPortable
variable was changed to/extensions/
because the path for the extensions folder in a portable VSCode instance, isextensions
code-settings-sync/src/service/pluginService.ts
Line 13 in 3646117
Ref to
extensions
path in vscode:https://github.com/Microsoft/vscode/blob/14f25a610224cea1b7fc97da63ad2304951f60a5/src/vs/platform/environment/node/environmentService.ts#L168
Fixes: shanalikhan#756
How Has This Been Tested?
The extension was "installed" in a portable vscode and executed to sync the settings. It works nicely.
Checklist: