Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): change portable extensions dir #1

Closed
wants to merge 1 commit into from
Closed

fix(extensions): change portable extensions dir #1

wants to merge 1 commit into from

Conversation

LuisUrrutia
Copy link

Short description of what this resolves:

Solves the issue shanalikhan#756 caused by a hardcoded extension dir.
This is a temporary workaround and we should use the env variables to check a valid extension dir instead of hardcoded ones:

Changes proposed in this pull request:

Fixes: shanalikhan#756

How Has This Been Tested?

The extension was "installed" in a portable vscode and executed to sync the settings. It works nicely.

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and Github Wiki.
  • I have updated the documentation and Wiki accordingly.

@chase9
Copy link
Owner

chase9 commented Feb 25, 2019

Hello Luis,

Thank you for your PR. However, since this is a fork, you're probably going to want to submit your PR to the main project at https://github.com/shanalikhan/code-settings-sync so that everyone can benefit from your work. Otherwise, I'd have to fast-forward and submit a PR of my own.

Let me know if you need any help doing this.

Chase

@chase9 chase9 closed this Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants