Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm run commands associated to testnet and mainnet #9

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix npm run commands associated to testnet and mainnet #9

merged 1 commit into from
Jun 28, 2023

Conversation

wfalcon0x
Copy link

Fixing the issue where npm run dev:testnet would also run npm run dev, which is overriding the value of the NEXT_PUBLIC_FLOW_NETWORK environment variable.
See the outputs below:

npm run dev:testnet

> fcl-next-scaffold@0.3.0 dev:testnet
> cross-env NEXT_PUBLIC_FLOW_NETWORK=testnet npm run dev


> fcl-next-scaffold@0.3.0 dev
> cross-env NEXT_PUBLIC_FLOW_NETWORK=local next dev

...

chasefleming
chasefleming approved these changes Jun 28, 2023
View reviewed changes
Copy link
Owner

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chasefleming chasefleming merged commit 05b2e30 into chasefleming:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasefleming chasefleming chasefleming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfalcon0x @chasefleming