add(mypy): type stubs for some ignored libraries #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic type stubs for some of the smaller libraries the bot and web_api use. Libraries with missing types that remain: - structlog, waiting on the release of its typed api - requests_async, need to convert to httpx which has types - asyncio_redis, maybe write stubs, or use a different client - django, stubs exist, last time we tried it, there were a number of false positives - stripe, no types currently, could probably write some minimal stubs rel: stripe/stripe-python#650
sbdchd
changed the title
chdsbd
reviewed
Nov 13, 2020
| from re import Match, RegexFlag | ||
| from typing import AnyStr, Optional, Pattern, overload | ||
|
|
||
| _FlagsType = RegexFlag |
There was a problem hiding this comment.
why do you assign here instead of using RegexFlag directly?
There was a problem hiding this comment.
idk, I just styled this after type shed
chdsbd
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic type stubs for some of the smaller libraries the bot and
web_api use.
We put the types in the
typingsfolder which we configure in the Mypy,but is also the default path that pyright looks at
so pylance should just work.
Libraries with missing types that remain:
false positives
rel: Feature Request: type annotations stripe/stripe-python#650
rel: indygreg/python-zstandard#120
rel: davidblewett/rure-python#23
rel: jazzband/dj-database-url#135