fix: Filter out che commands imported by plugins/contributions #194
Conversation
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
azatsarynnyy
requested review from
RomanNikitenko and
vitaliy-guliy
as code owners
| .filter(command => !command.attributes || (command.attributes as any)['controller.devfile.io/imported-by'] !== 'editor') | ||
| .filter(command => !command.attributes || (command.attributes as any)['controller.devfile.io/imported-by'] === undefined) |
There was a problem hiding this comment.
Another case that just occurred to me that we may want to cover -- there's a special case when devfiles use parents. In this case, the command would have the attribute controller.devfile.io/imported-by: "parent" (hard-coded, by DWO). Should we include those commands?
E.g. see the example in this issue: eclipse-che/che#22103 -- we likely want to include the commands from the java-maven parent.
There was a problem hiding this comment.
Good catch. Thanks @amisevsk !
I've prepared a fix in the draft PR https://github.com/che-incubator/che-code/pull/197/files. Will test it once the dogfoding instance is fixed (eclipse-che/che#22108) and merge.
|
Build 3.6 :: code_3.x/496: Console, Changes, Git Data |
|
Build 3.6 :: sync-to-downstream_3.x/2799: Console, Changes, Git Data |
What does this PR do?
Filters out che commands imported by plugins/contributions as they are not expected to be run by the user.
What issues does this PR fix?
eclipse-che/che#22098
implements the suggestion #192 (review)
How to test this PR?
init-che-code-commandcommand among thedevfile-type Tasks.