Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restart From Local Devfile action #236

Merged
merged 1 commit into from
Jun 13, 2023
Merged

fix: Restart From Local Devfile action #236

merged 1 commit into from
Jun 13, 2023

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented May 31, 2023 •
edited
Loading

What does this PR do?

Allows to avoid requests to the plugin registry for the new Devfile context generation.

What issues does this PR fix?

should fix eclipse-che/che#22242

How to test this PR?

  1. Start a workspace from the repo, it contains a reference to the image that was built for the current pull request.
  2. Provide a change to the devfile
  3. Restart the workspace using Restart From Local Devfile action

@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited
Loading

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@RomanNikitenko RomanNikitenko mentioned this pull request May 31, 2023
Closed
@github-actions

This comment was marked as outdated.

Sign in to view
8 similar comments
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@RomanNikitenko
fix: Avoid requests to plugin registry to get editor's devfile.yaml
060c657 
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko changed the title fix: Use certificate authority for the axios instance fix: Restart From Local Devfile action Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@RomanNikitenko RomanNikitenko marked this pull request as ready for review June 6, 2023 11:10
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-236-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-236-dev-amd64

@RomanNikitenko RomanNikitenko merged commit 70a3cc0 into che-incubator:main Jun 13, 2023
@RomanNikitenko RomanNikitenko deleted the fix-restart-from-devfile branch June 13, 2023 18:02
@RomanNikitenko RomanNikitenko mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

@l0rd l0rd Awaiting requested review from l0rd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade devfile on existing workspace no more working on 7.67.0
2 participants
@RomanNikitenko @azatsarynnyy