Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use universal developer image for dev container #253

Merged
merged 17 commits into from
Nov 7, 2023
Merged

Use universal developer image for dev container #253

merged 17 commits into from
Nov 7, 2023

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Jun 30, 2023 •
edited
Loading

What does this PR do?

  • Inherits che-code-dev image from Universal Developer Image
  • Adds few commands to build che-code image with podman

What issues does this PR fix?

eclipse-che/che#22292

How to test this PR?

Do following:

Screenshot from 2023-09-07 16-01-35

Should have like following:

Screenshot from 2023-06-26 17-50-43

Screenshot from 2023-06-26 17-49-35

Note that:

Depends on devfile/developer-images#117

@github-actions
Copy link

github-actions bot commented Jun 30, 2023 •
edited
Loading

Click here to review and test in web IDE: Contribute

@vitaliy-guliy vitaliy-guliy changed the title chore: use universal developer image for dev container Use universal developer image for dev container Jun 30, 2023
@vitaliy-guliy vitaliy-guliy mentioned this pull request Jun 30, 2023
Closed
@vitaliy-guliy
Copy link
Contributor Author

@azatsarynnyy @RomanNikitenko could you please guys review this pull request and approve or deny it?
It has been opened already two weeks, it would be nice if we move forward with updating of che-code dev image.

RomanNikitenko
RomanNikitenko reviewed Jul 12, 2023
View reviewed changes
build/dockerfiles/dev.Dockerfile
@@ -6,81 +6,49 @@
# SPDX-License-Identifier: EPL-2.0
#

# https://quay.io/eclipse/che-machine-exec#^7\.
FROM quay.io/eclipse/che-machine-exec:7.56.0 as machine-exec
FROM quay.io/devfile/universal-developer-image:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitaliy-guliy
As I mentioned in your previous PR #246 (comment)
I don't think we should bring UDI for the Che-Code development

But in general it's OK for me to merge the current PR, if the changes look good for other reviewers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benefit of using UDI as the base image is that all UDI layers are already in the nodes of the cluster (especially if kube-image-puller is configured, so it should be really fast to pull images based on UDI on a kube cluster.

@azatsarynnyy

This comment was marked as outdated.

Sign in to view
@vitaliy-guliy vitaliy-guliy marked this pull request as draft August 15, 2023 09:07
@vitaliy-guliy
chore: use universal developer image for dev container
1c86198 
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@vitaliy-guliy vitaliy-guliy reopened this Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 7, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 19, 2023
@che-incubator che-incubator deleted a comment from github-actions bot Sep 19, 2023
@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review September 19, 2023 09:51
@vitaliy-guliy vitaliy-guliy marked this pull request as draft September 27, 2023 17:29
@vitaliy-guliy
fix: revert back .p10k.zsh
882e7ea 
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@vitaliy-guliy
fix: revert back original github actions names
0e5ab28 
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-253-dev-amd64

@vitaliy-guliy
Copy link
Contributor Author

@azatsarynnyy I cannot say for sure, but seems the terminal looks like as it was before

Screenshot from 2023-10-04 16-27-32

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-253-amd64

l0rd
l0rd reviewed Oct 4, 2023
View reviewed changes
devfile.yaml Outdated Show resolved Hide resolved
azatsarynnyy
azatsarynnyy approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks Vitaliy for your cooperation in addressing all my comments 🙂

@vitaliy-guliy
Merge branch 'main' into switch-to-udi-merge
8cd0a00 
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@vitaliy-guliy
chore: code refactoring
7d60383 
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@github-actions GitHub Actions
Copy link

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-253-dev-amd64

@github-actions GitHub Actions
Copy link

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-253-amd64

@vitaliy-guliy
chore: code refactoring
46a2225 
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-253-dev-amd64

@vitaliy-guliy
chore: remove creating of containers.conf
c7b5b70 
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Pull Request Dev image published:
👉 quay.io/che-incubator-pull-requests/che-code-dev:pr-253-dev-amd64

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Pull Request Che-Code image published:
👉 quay.io/che-incubator-pull-requests/che-code:pr-253-amd64

@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review November 7, 2023 08:40
@vitaliy-guliy vitaliy-guliy merged commit 6d47882 into main Nov 7, 2023
6 checks passed
@vitaliy-guliy vitaliy-guliy deleted the switch-to-udi-merge branch November 7, 2023 10:39
@vitaliy-guliy vitaliy-guliy restored the switch-to-udi-merge branch November 7, 2023 10:39
@RomanNikitenko RomanNikitenko mentioned this pull request Nov 8, 2023
Closed
@vitaliy-guliy vitaliy-guliy mentioned this pull request Nov 17, 2023
Merged
@vitaliy-guliy vitaliy-guliy deleted the switch-to-udi-merge branch February 8, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanNikitenko RomanNikitenko RomanNikitenko left review comments

@l0rd l0rd l0rd left review comments

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitaliy-guliy @azatsarynnyy @l0rd @RomanNikitenko