Rebase against the upstream + Migrate to 18 Node.js #265

RomanNikitenko · 2023-08-09T08:05:47Z

What does this PR do?

Rebase against the upstream
Some adaptation for migration to 18 Node.js

What issues does this PR fix?

eclipse-che/che#22425
eclipse-che/che#22426

How to test this PR?

jobs should be green
the PR includes migration to 18 Node.js, so testing any use cases is helpful

github-actions · 2023-08-09T08:06:05Z

Click here to review and test in web IDE:

github-actions · 2023-08-09T14:05:22Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-265-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-265-dev-amd64

…(#190067) Don't uninstall application-scoped extensions

…dding specificity (#190077) * bugfix on selected list item reverting and added important * removed !important and added specificity

* Realign slash command content widget in panel chat * Align pill text with input text * Vertically align all content in panel chat input --------- Co-authored-by: David Dossett <ddossett@microsoft.com>

* Update 1DS and add back envelope * Update missed 1DS packages

…k (#181231) * Better paths matching for move to existing file quickpick * fix resolving selected item * fix: select file dialog point to existing file * skip computing if use coalesce * Improve typings --------- Co-authored-by: Matt Bierner <matb@microsoft.com>

Fish integration: Use -- in string to signify beginning of positional…

Part of #30522

* Add tunnel activation event Fixes #188730 * Refactor

Add terminal/context menu contribution

…nfiguration.ts Co-authored-by: Megan Rogge <merogge@microsoft.com>

* Update port attributes arguments to be a property bag Part of #115616 * Gracefully handle API breakage

Add terminal/title/context menu contribution

Add more keywords to UnfocusedViewOpacity

apply `when` clauses to accessible view menu, fix some bugs, split code across files

…d-view add `focusedView` variable to window title

This ensures we pass along all regex flags instead of just the subset we had code for

…accessibility improve accessibility of inline completions

Doesn't appear to be used anywhere besides tests

To do this, I've pulled `QuickInputController` into its own file since `quickInput.ts` was getting too big... And then I made another thing that extends `QuickInput` that hides pretty much everything but does allow for a title bar. This could be useful for more "QuickWebView" type experiences if we wanna light anything like that up.

vscode-upstream-sha1: ccb95fd

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

github-actions · 2023-08-17T10:41:53Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-265-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-265-dev-amd64

github-actions · 2023-08-17T12:30:32Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-265-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-265-dev-amd64

github-actions · 2023-08-17T21:48:17Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-265-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-265-dev-amd64

github-actions · 2023-08-21T11:39:17Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-265-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-265-dev-amd64

github-actions · 2023-08-22T06:27:02Z

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-265-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-265-dev-amd64

This was referenced Aug 9, 2023

Automatic git-rebase is broken for the Che-Code eclipse-che/che#22428

Closed

Migrate to Node.js 18 version for the Che-Code eclipse-che/che#22426

Closed

joyceerhl and others added 26 commits August 9, 2023 12:09

Don't uninstall application-scoped extensions when importing profile …

b9d174e

…(#190067) Don't uninstall application-scoped extensions

Reverting #189955 to fix issue with selectors in certain themes and a…

1094b5d

…dding specificity (#190077) * bugfix on selected list item reverting and added important * removed !important and added specificity

forwarding: fix tearing down process too early (#190081)

a0e56dc

Realign slash command content widget in panel chat (#190053)

01f748f

* Realign slash command content widget in panel chat * Align pill text with input text * Vertically align all content in panel chat input --------- Co-authored-by: David Dossett <ddossett@microsoft.com>

Fix compilation

8bd8248

Update 1DS and add back envelope (#190056)

3ee5c83

* Update 1DS and add back envelope * Update missed 1DS packages

fix issues

2116696

fix conflict

30256ad

Merge pull request #189994 from davedash/davedash-patch-1

36fa6d4

Fish integration: Use -- in string to signify beginning of positional…

Add more keywords to UnfocusedViewOpacity

34122ea

Part of #30522

Add tunnel activation event (#189936)

a3e2f15

* Add tunnel activation event Fixes #188730 * Refactor

fix cyclic dependency issue

6c20ed9

use AccessibilityCommandIds for more commands

a916726

more replacements

0d879f7

Merge pull request #190071 from microsoft/tyriar/79034_instance_menu

31b4ba6

Add terminal/context menu contribution

logic for when menu item is shown, copy text version of image

8d73d94

Merge branch 'main' into tyriar/79034_tab_menu

e4b8865

Update src/vs/workbench/contrib/accessibility/browser/accessibilityCo…

66a4d77

…nfiguration.ts Co-authored-by: Megan Rogge <merogge@microsoft.com>

Update port attributes arguments to be a property bag (#189976)

8429ea9

* Update port attributes arguments to be a property bag Part of #115616 * Gracefully handle API breakage

Merge pull request #190079 from microsoft/tyriar/79034_tab_menu

0f162e1

Add terminal/title/context menu contribution

Merge pull request #190098 from microsoft/tyriar/30522_2

0f2e35c

Add more keywords to UnfocusedViewOpacity

Don't touch the vscode API types in extHost.protocol

4ace970

Handle command converter disposables

ed9c629

Merge pull request #190064 from microsoft/merogge/acc-view-symb-polish

48a93db

apply `when` clauses to accessible view menu, fix some bugs, split code across files

Fix content widget overwritten warning (#190105)

bf217d2

meganrogge and others added 11 commits August 16, 2023 13:25

add focusedView variable to window title

e5921ad

use name

6ea1bd3

Fix using variables with uppercase characters (#190606)

6ce0f37

Merge pull request #190613 from microsoft/merogge/window-title-focuse…

29736e1

…d-view add `focusedView` variable to window title

Use regexp.flags instead of custom function (#190617)

f7dc5e1

This ensures we pass along all regex flags instead of just the subset we had code for

Merge pull request #190531 from microsoft/merogge/inline-completions-…

4e59c47

…accessibility improve accessibility of inline completions

Remove regExpContainsBackreference (#190621)

1afcd2c

Doesn't appear to be used anywhere besides tests

Bump TS version for building VS Code (#190622)

376d0b1

Rebase against the upstream ccb95fd

2a05177

vscode-upstream-sha1: ccb95fd

Migrate to 18 Node.js

494760c

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

RomanNikitenko force-pushed the fix-rebase branch from ab2fd89 to 494760c Compare August 17, 2023 09:22

RomanNikitenko changed the title ~~Rebase against the upstream~~ Rebase against the upstream + Migrate to 18 Node.js Aug 17, 2023

RomanNikitenko marked this pull request as ready for review August 17, 2023 14:33

RomanNikitenko requested review from azatsarynnyy, vitaliy-guliy and l0rd as code owners August 17, 2023 14:33

RomanNikitenko mentioned this pull request Aug 17, 2023

chore: Adapt dockerfile to moving VS Code to 18 Node.js redhat-developer/devspaces-images#495

Merged

azatsarynnyy approved these changes Aug 17, 2023

View reviewed changes

Merge branch 'main' into fix-rebase

cd80349

azatsarynnyy enabled auto-merge August 21, 2023 10:20

azatsarynnyy merged commit b6ba5c4 into che-incubator:main Aug 21, 2023
1 of 2 checks passed

RomanNikitenko deleted the fix-rebase branch August 22, 2023 17:38

azatsarynnyy mentioned this pull request Aug 29, 2023

Che-Code automatic rebase against upstream VS Code is failed eclipse-che/che#22425

Closed

dmytro-ndp mentioned this pull request Sep 5, 2023

SmokeTests fails against Eclipse Che next version eclipse-che/che#22450

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase against the upstream + Migrate to 18 Node.js #265

Rebase against the upstream + Migrate to 18 Node.js #265

RomanNikitenko commented Aug 9, 2023 •

edited

Loading

github-actions bot commented Aug 9, 2023 •

edited

Loading

github-actions bot commented Aug 9, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 21, 2023

github-actions bot commented Aug 22, 2023

Rebase against the upstream + Migrate to 18 Node.js #265

Rebase against the upstream + Migrate to 18 Node.js #265

Conversation

RomanNikitenko commented Aug 9, 2023 • edited Loading

What does this PR do?

What issues does this PR fix?

How to test this PR?

github-actions bot commented Aug 9, 2023 • edited Loading

github-actions bot commented Aug 9, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 21, 2023

github-actions bot commented Aug 22, 2023

RomanNikitenko commented Aug 9, 2023 •

edited

Loading

github-actions bot commented Aug 9, 2023 •

edited

Loading