Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Stop Workspace command behavior with Stop Workspace and Redirect to Dashboard #278

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

This PR replaces Stop Workspace command behavior with Stop Workspace and Redirect to Dashboard. Stop Workspace command will be removed from package.json but still exists for using by other commands.

What issues does this PR fix?

eclipse-che/che#22269

How to test this PR?

Open Command Palette and start Eclipse Che: Stop Workspace command. Wait that workspace is stopped and web page redirected to Dashboard. The workspace has Stopped status.

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-278-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-278-dev-amd64

@SkorikSergey
Copy link
Contributor Author

Works as expected from Command Palette and Status Bar
screencast-che-dogfooding apps che-dev x6e0 p1 openshiftapps com-2023 09 29-14_25_48
screencast-che-dogfooding apps che-dev x6e0 p1 openshiftapps com-2023 09 29-14_24_02

Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well for me!

@RomanNikitenko RomanNikitenko merged commit ea392b0 into che-incubator:main Sep 29, 2023
3 checks passed
@devstudio-release
Copy link

Build 3.10 :: code_3.x/949: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: code_3.x/949: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4840 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/1964: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.x/4841: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4641 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.x/2115: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4841 triggered

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1432: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4479: SUCCESS

Detected new images: rebuild operator-bundle
* code; /DS_CI/operator-bundle_3.x/2115 triggered

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1432: SUCCESS

3.10.0 CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants