Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade kubernetes/client-node version #286

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Oct 16, 2023

What does this PR do?

After the last alignment with upstream Che-Code build fails with the error: Module parse failed 'import' and 'export' may appear only with 'sourceType: module', see eclipse-che/che#22606.
I think it's because of the underscore dependency, as there is //# sourceMappingURL=underscore-esm.js.map at the end of the error stack.
The dependency comes as a transitive one - kubernetes/client-node package brings it. The new version of the kubernetes/client-node doesn't have this dependency. So upgrade allows to avoid the error.

What issues does this PR fix?

eclipse-che/che#22606

How to test this PR?

  • the jobs should be green
  • check functionality related to the kubernetes usage, like github authentication, resource monitor, etc.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-286-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-286-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-286-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-286-dev-amd64

@RomanNikitenko RomanNikitenko merged commit baf3cbc into che-incubator:main Oct 16, 2023
2 of 3 checks passed
@RomanNikitenko RomanNikitenko deleted the kubernetes-client-node-upgrade branch October 16, 2023 13:05
@devstudio-release
Copy link

Build 3.10 :: code_3.x/956: Console, Changes, Git Data

@devstudio-release
Copy link

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-286-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-286-dev-amd64

1 similar comment
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-286-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-286-dev-amd64

@devstudio-release
Copy link

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-286-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-286-dev-amd64

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: code_3.x/956: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4962 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/2004: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.x/4963: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4786 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.x/2156: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4963 triggered

@devstudio-release
Copy link

Build 3.10 :: dsc_3.x/1484: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.x/4625: SUCCESS

Detected new images: rebuild operator-bundle
* code; /DS_CI/operator-bundle_3.x/2156 triggered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants