Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep devworkspace attributes when restarting from local devfile #465

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Dec 9, 2024

What does this PR do?

  • Persists devworkspace attributes when restarting the workspace from local devfile.

  • Prevents appearing claim-devworkspace PVC wen restarting the workspace from local devfile.
    Screenshot from 2024-12-09 15-41-35

What issues does this PR fix?

eclipse-che/che#23110

How to test this PR?

  • create a workspace using the editor quay.io/che-incubator-pull-requests/che-code:pr-465-amd64
  • open the OpenShift console, go to Storage -> PersistentVolumeClaims
  • return back to the workspace, restart it from local devfile
  • switch to the OpenShift console again and refresh the page. claim-devworkspace PVS should not be created
  • return back to the workspace, it should be restarted successfully

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Copy link

github-actions bot commented Dec 9, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Dec 9, 2024

Signed-off-by: vitaliy-guliy <vgulyy@redhat.com>
Copy link

github-actions bot commented Dec 9, 2024

@vitaliy-guliy vitaliy-guliy marked this pull request as ready for review December 9, 2024 16:27
@vitaliy-guliy vitaliy-guliy merged commit 311493a into main Dec 9, 2024
7 checks passed
@vitaliy-guliy vitaliy-guliy deleted the keep-storage-type-attribute branch December 9, 2024 16:53
@devspacesbuild
Copy link

Build 3.19 :: code_3.x/1515: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.19 :: code_3.x/1516: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8336: FAILURE

code : 3.x :: Failed in 66145164 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants