Skip to content

Commit

Permalink
fix(operator): fix deploying on K8s with operator and TLS
Browse files Browse the repository at this point in the history
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
  • Loading branch information
sleshchenko committed Aug 2, 2019
1 parent 3985843 commit eae1e1a
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,10 @@ OPTIONS
-p, --platform=platform [default: minikube] Type of Kubernetes platform. Valid values are
"minikube", "minishift", "k8s", "openshift", "microk8s".
-s, --tls Enable TLS encryption. Note that `che-tls` with TLS certificate must be
-s, --tls Enable TLS encryption.
Note that for kubernetes `che-tls` with TLS certificate must be
created in the configured namespace.
For OpenShift, router will use default cluster certificates.
--self-signed-cert Authorize usage of self signed certificates for encryption.
Expand Down
3 changes: 3 additions & 0 deletions src/api/kube.ts
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,9 @@ export class KubeHelper {
yamlCr.spec.server.cheImageTag = imageAndTag.length === 2 ? imageAndTag[1] : 'latest'
yamlCr.spec.auth.openShiftoAuth = flags['os-oauth']
yamlCr.spec.server.tlsSupport = flags.tls
if (flags.tls) {
yamlCr.spec.k8s.tlsSecretName = `che-tls`
}
yamlCr.spec.server.selfSignedCert = flags['self-signed-cert']
yamlCr.spec.k8s.ingressDomain = flags.domain
let pluginRegistryUrl = flags['plugin-registry-url']
Expand Down
4 changes: 3 additions & 1 deletion src/commands/server/start.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ export default class Start extends Command {
}),
tls: flags.boolean({
char: 's',
description: 'Enable TLS encryption. Note that `che-tls` with TLS certificate must be created in the configured namespace.',
description: `Enable TLS encryption.
Note that for kubernetes 'che-tls' with TLS certificate must be created in the configured namespace.
For OpenShift, router will use default cluster certificates.`,
default: false
}),
'self-signed-cert': flags.boolean({
Expand Down

0 comments on commit eae1e1a

Please sign in to comment.