Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command server:start fails if che helm chart has status DELETE or DELETING #18

Closed
l0rd opened this issue Dec 12, 2018 · 3 comments · Fixed by #200
Closed

Command server:start fails if che helm chart has status DELETE or DELETING #18

l0rd opened this issue Dec 12, 2018 · 3 comments · Fixed by #200
Assignees
Labels
bug Something isn't working

Comments

@l0rd
Copy link
Collaborator

l0rd commented Dec 12, 2018

If Che Helm Chart is in DELETING status:

$ helm list --all
NAME	REVISION	UPDATED                 	STATUS  	CHART    	APP VERSION	NAMESPACE
che 	1       	Tue Dec 11 19:57:47 2018	DELETING	che-0.1.0	           	kube-che

and the command server:start is executed the following error is shown:

  ✔ Verify if namespace kube-che exist
  ↓ Verify if Che server is already running [skipped]
    → Che namespace doesn't exist.
  ✖ Deploy Che Server
    → Error: UPGRADE FAILED: "che" has no deployed releases
    Waiting for Che Server to start and respond
    Retrieving Che Server URL
Error: Command failed: /bin/sh -c helm upgrade /
                            --install che /
                            --namespace kube-che /
                            --set global.ingressDomain=$(minikube ip).nip.io /
                            --set cheImage=eclipse/che-server:nightly /
                            --set global.cheWorkspacesNamespace=kube-che /
                            /Users/mloriedo/Library/Caches/chectl/templates/kubernetes/helm/che/
Error: UPGRADE FAILED: "che" has no deployed releases
    at makeError (~/github/chectl/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (~/github/chectl/node_modules/execa/index.js:278:16)
    at <anonymous>
@l0rd l0rd changed the title Command server:start fails if che server is in DELETING status Command server:start fails if che helm chart has status DELETE or DELETING Mar 4, 2019
@l0rd
Copy link
Collaborator Author

l0rd commented Mar 4, 2019

To reproduce it (supposing that Che chart has already been installed):

$ helm delete che
Error: deletion completed with 4 error(s): release "che": object "" not found, skipping delete; release "che": object "" not found, skipping delete; release "che": object "" not found, skipping delete; release "che": object "" not found, skipping delete
$ helm list -a
NAME	REVISION	UPDATED                 	STATUS 	CHART    	APP VERSION	NAMESPACE
che 	4       	Sat Mar  2 03:31:52 2019	DELETED	che-0.1.0	           	kube-che
$ ./bin/run server:start
  ✔ Platform preflight checklist (minikube) ✈️
    ✔ Verify if kubectl is installed
    ✔ Verify if minikube is installed
    ✔ Verify if minikube is running
    ↓ Start minikube [skipped]
      → Minikube is already running.
    ✔ Verify if minikube ingress addon is enabled
    ↓ Enable minikube ingress addon [skipped]
      → Ingress addon is already enabled.
    ✔ Retrieving minikube IP and domain for ingress URLs...192.168.64.47.nip.io.
  ❯ Running the installer (Helm) 🏎️
    ✔ Verify if helm is installed
    ✔ Create Tiller Role Binding...it already exist.
    ✔ Create Tiller Service Account...it already exist.
    ✔ Create Tiller RBAC
    ✔ Create Tiller Service...it already exist.
    ✔ Preparing Che Helm Chart...done.
    ✔ Updating Helm Chart dependencies...done.
    ✖ Deploying Che Helm Chart
      → Error: UPGRADE FAILED: "che" has no deployed releases
Error: Command failed: /bin/sh -c helm upgrade /
                            --install che /
                            --namespace kube-che /
                            --set global.ingressDomain=192.168.64.47.nip.io /
                            --set cheImage=eclipse/che-server:nightly /
                            --set global.cheWorkspacesNamespace=kube-che /
                              /Users/mloriedo/Library/Caches/chectl/templates/kubernetes/helm/che/
Error: UPGRADE FAILED: "che" has no deployed releases
    at makeError (~/github/chectl/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (~/github/chectl/node_modules/execa/index.js:278:16)

@l0rd
Copy link
Collaborator Author

l0rd commented Mar 4, 2019

Related to helm/helm#3208 (comment)

@l0rd
Copy link
Collaborator Author

l0rd commented Mar 4, 2019

We should probably implement what is described in this issue comment helm/helm#3353 (comment):

helm upgrade --install

if FAIL then

  • if revision=1
  • then helm delete --purge
  • else helm rollback

@l0rd l0rd added the bug Something isn't working label Mar 27, 2019
@benoitf benoitf self-assigned this Jul 1, 2019
benoitf added a commit that referenced this issue Jul 3, 2019
…charts based on revisions

Fix #18

Change-Id: I30a7e4462d5c10219c216ee528e73f2853aeaba5
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Jul 3, 2019
…charts based on revisions

Fix #18

Change-Id: I30a7e4462d5c10219c216ee528e73f2853aeaba5
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Jul 3, 2019
…charts based on revisions

Fix #18

Change-Id: I30a7e4462d5c10219c216ee528e73f2853aeaba5
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Jul 3, 2019
…charts based on revisions

Fix #18

Change-Id: I30a7e4462d5c10219c216ee528e73f2853aeaba5
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants