Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inspect checluster status and fail if status.reason is not empty #1259

Merged
merged 3 commits into from
May 31, 2021

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented May 24, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

  • Inspect checluster status and fail if status.reason is not empty (when there is an error on operator side)

Screenshot/screencast of this PR

    ❯ Operator pod bootstrap
      ✖ Scheduling...failed
        → Eclipse Che operator failed, reason: Fail, message: Fail for some reason. Consider increasing error recheck timeout with --k8spoderrorrechecktimeout flag.
        Downloading images
        Starting
      Prepare Eclipse Che cluster CR
 ›   Error: Error: Eclipse Che operator failed, reason: Fail, message: Fail for some reason. Consider increasing error recheck timeout with --k8spoderrorrechecktimeout flag.
 ›   Command server:deploy failed. Error log: /home/tolusha/.cache/chectl/error.log

What issues does this PR fix or reference?

eclipse-che/che#19284

How to test this PR?

  1. Deploy Eclipse Che using custom operator image with setting not empty status details
deploy.SetStatusDetails(deployContext, "Fail", "Fail for some reason", "")

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title Inspect checluster status and fail if status.reason is not empty feat: Inspect checluster status and fail if status.reason is not empty May 24, 2021
src/tasks/kube.ts Outdated Show resolved Hide resolved
src/tasks/kube.ts Outdated Show resolved Hide resolved
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Collaborator Author

tolusha commented May 27, 2021

/retest

@tolusha
Copy link
Collaborator Author

tolusha commented May 27, 2021

@mmorhun
Addressed you remarks

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented May 31, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label May 31, 2021
@mmorhun mmorhun removed their assignment May 31, 2021
@tolusha tolusha merged commit f985bc2 into main May 31, 2021
@tolusha tolusha deleted the 19284 branch May 31, 2021 13:57
@l0rd
Copy link
Collaborator

l0rd commented Jun 2, 2021

@benoitf I think that the milestone has failed to be assigned here

@che-bot che-bot added this to the 7.32 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants