Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: get rid of bcrypt #1756

Merged
merged 2 commits into from
Oct 11, 2021
Merged

ci: get rid of bcrypt #1756

merged 2 commits into from
Oct 11, 2021

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Oct 11, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

dex username and password are fixed.
bcrypt dependency is not needed.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19366

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@@ -45,6 +44,8 @@ export class DexTasks {

private static readonly DEX_PASSWORD = 'admin'

private static readonly DEX_PASSWORD_HAS = '$2a$12$Cnptj8keBvBFuQkNebteYuGHnZRNKT6MivLrGmFRaTxrlyfEAOrSa'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ^(

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Oct 11, 2021
@tolusha tolusha merged commit 735e1ac into main Oct 11, 2021
@tolusha tolusha deleted the fix branch October 11, 2021 12:19
@che-bot che-bot added this to the 7.38 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants