fix: wait for some time when che-operator updated status with an error #1763
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
tolusha
requested review from
AndrienkoAleksandr,
flacatus and
mmorhun
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1763 +/- ##
==========================================
- Coverage 10.77% 10.77% -0.01%
==========================================
Files 64 64
Lines 7153 7155 +2
Branches 1212 1212
==========================================
Hits 771 771
- Misses 6382 6384 +2
Continue to review full report at Codecov.
|
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
src/tasks/kube.ts
Outdated
| // for instance we need some time for pvc provisioning... | ||
|
|
||
| if (cheClusterFailState || podFailState) { | ||
| // wait some time to recheck |
There was a problem hiding this comment.
I think we should do something like:
await cli.wait(10 * 1000)
i += 10
continueOtherwise, if we face a problem that is resolved in a dozen of seconds, current code will wait whole minute.
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
/retest |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Wait for some time when che-operator updated status with an error.
It allows to continue deploying when problem is fixed.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#19978
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.