Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dex oauth callback to match openshift setup #1798

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Oct 26, 2021

Signed-off-by: Michal Vala mvala@redhat.com

What does this PR do?

Changes dex configuration. Oauth2 callback on openshift is currently set tu /oauth/callback, so it will be easier for the rest of the system to use same path.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

part of eclipse-che/che#20635

How to test this PR?

deploy on minikube with

spec:
  auth:
    nativeUserMode: true

and check dex configmap in dex namespace. It must have something like this:

staticClients:
    - id: eclipse-che
      redirectURIs:
      - 'https://che-eclipse-che.192.168.39.163.nip.io/oauth/callback'

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@sparkoo sparkoo changed the title update dex oauth callback to match openshift setup fix: update dex oauth callback to match openshift setup Oct 26, 2021
Signed-off-by: Michal Vala <mvala@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, mmorhun, sparkoo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sparkoo
Copy link
Member Author

sparkoo commented Oct 26, 2021

/retest

@sparkoo sparkoo merged commit aa964ec into che-incubator:main Oct 27, 2021
@sparkoo sparkoo deleted the gh20635-dexCallbackPath branch October 27, 2021 06:19
@che-bot che-bot added this to the 7.39 milestone Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants