Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform): server:start with specified domain #239

Merged
merged 1 commit into from
Aug 2, 2019
Merged

fix(platform): server:start with specified domain #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/platforms/microk8s.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export class MicroK8sHelper {
}
},
{ title: 'Retrieving microk8s IP and domain for ingress URLs',
enabled: () => flags.domain !== undefined,
enabled: () => !flags.domain,
task: async (_ctx: any, task: any) => {
const ip = await this.getMicroK8sIP()
flags.domain = ip + '.nip.io'
Expand Down
2 changes: 1 addition & 1 deletion src/platforms/minikube.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class MinikubeHelper {
task: () => this.enableIngressAddon()
},
{ title: 'Retrieving minikube IP and domain for ingress URLs',
enabled: () => flags.domain !== undefined,
enabled: () => !flags.domain,
task: async (_ctx: any, task: any) => {
const ip = await this.getMinikubeIP()
flags.domain = ip + '.nip.io'
Expand Down
2 changes: 1 addition & 1 deletion src/platforms/minishift.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class MinishiftHelper {
// { title: 'Verify minishift memory configuration', skip: () => 'Not implemented yet', task: () => {}},
// { title: 'Verify kubernetes version', skip: () => 'Not implemented yet', task: () => {}},
{ title: 'Retrieving minishift IP and domain for routes URLs',
enabled: () => flags.domain !== undefined,
enabled: () => !flags.domain,
task: async (_ctx: any, task: any) => {
const ip = await this.getMinishiftIP()
flags.domain = ip + '.nip.io'
Expand Down