feat: Add ability to set up Che workspace and Postgres pvc class names using arguments. #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
azatsarynnyy,
benoitf,
l0rd,
rhopp and
vparfonov
as code owners
16 tasks
tolusha
reviewed
Jan 15, 2020
| }), | ||
| 'workspace-pvc-storage-class-name': string({ | ||
| description: 'persistent volume(s) storage class name to use to store Eclipse Che workspaces data', | ||
| env: 'CHE_INFRA_KUBERNETES_PVC_STORAGE__CLASS__NAME', |
There was a problem hiding this comment.
Maybe CHE_INFRA_KUBERNETES_WORKSPACE_PVC_STORAGE__CLASS__NAME
| }), | ||
| 'postgres-pvc-storage-class-name': string({ | ||
| description: 'persistent volume storage class name to use to store Eclipse Che Postgres database', | ||
| default: '' |
There was a problem hiding this comment.
env: 'CHE_INFRA_KUBERNETES_POSTGRESS_PVC_STORAGE__CLASS__NAME',
| @@ -321,6 +321,14 @@ error: E_COMMAND_FAILED`) | |||
| ctx.isDevfileRegistryDeployed = true | |||
| } | |||
|
|
|||
| if (flags['workspace-pvc-storage-class-name']) { | |||
| setOptions.push(`--set global.cheWorkspacePVCStorageClassName=${flags['workspace-pvc-storage-class-name']}`) | |||
There was a problem hiding this comment.
Just wondering if we don't face any errors if storage class name is undefined
tolusha
changed the title
tolusha
approved these changes
Jan 15, 2020
Closed
35 tasks
17 tasks
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ability to set up Che workspace and Postgres pvc class names using arguments.
What issues does this PR fix or reference?
eclipse-che/che#15157
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com