Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use TLS secrets autogeneration mechanism in chectl #679

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Apr 29, 2020

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Makes usable the work done in eclipse-che/che#16546.
So now, a user may just run:

chectl server:start --platform=<platform> --self-signed-certificated

At the end of the command execution log will be a message with path to self-signed certificate which should be imported into user's browser and link to the docs how to do it.

Despite the work done toward TLS direction, it is still possible (but deprecated) to use no-tls mode. As usual, create patch.yaml with following content:

spec:
  server:
    tlsSupport: false

and then pass --che-operator-cr-patch-yaml=/path/to/pathc.yaml to chectl.

In case of using Openshift like infrastuctures with self-signed certiicate, where the certificate is embedded into cluster, chectl will retrieve it as was described above.

This PR sets operator installer as default one.

What issues does this PR fix or reference?

eclipse-che/che#16052

What was tested

I've tested Che deployment process and a workspace start:

  • on Minikube:
    • operator installer
    • helm installer
    • operator installer in no-tls mode
  • on CRC:
    • operator installer
    • olm installer

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun requested a review from l0rd as a code owner April 29, 2020 15:23
@mmorhun mmorhun self-assigned this Apr 29, 2020
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@mmorhun mmorhun changed the title Use TLS secrets autogeneration mechanism in chectl feat: Use TLS secrets autogeneration mechanism in chectl Apr 30, 2020
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@tolusha
Copy link
Collaborator

tolusha commented Apr 30, 2020

  ✔ Retrieving Eclipse Che server URL... https://che-che.192.168.99.100.nip.io
    ✔ Eclipse Che status check
  ✔ Retrieving Che self-signed CA certificate... is exported to /home/tolusha/cheCA.crt
  ✔ Show important messages
    ✔ ❗[MANUAL ACTION REQUIRED] Please add Che self-signed CA certificate into your browser: /home/tolusha/cheCA.crt.
   Documentaton how to add a CA certificate into a browser: https://www.eclipse.org/che/docs/che-7/installing-che-in-tls-mode-with-self-signed-certificates/#using-che-with-tls_installing-che-in-tls-mode-with-self-signed-certificates
Command server:start has completed successfully.

nice!!!

@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@che-osio-probot-app
Copy link

Open Developer Workspace:
Contribute

@dmytro-ndp
Copy link
Contributor

@mmorhun: I have checked Che nightly/PR jobs - they are ready to these changes.
And, IMHO, we shouldn't forget about Eclipse Che docs update https://github.com/eclipse/che-docs/

@nickboldt
Copy link
Collaborator

For the record, setting operator as the default changes nothing in crwctl where that's already the default, and where tlsSupport: false is unsupported and highly not recommended (unless you like your IDE to look half-broken).

@tolusha
Copy link
Collaborator

tolusha commented Apr 30, 2020

@dmytro-ndp
We are planning to update docs in the next sprint

@mmorhun mmorhun merged commit 7e99d04 into master Apr 30, 2020
@mmorhun mmorhun deleted the che-16052 branch April 30, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants