Skip to content

Commit

Permalink
bug: Fix proxy auth assignment while creating tunnel agent (#968)
Browse files Browse the repository at this point in the history
Co-authored-by: Abhiman Kolte <akolte@icloud.com>
  • Loading branch information
abhimanbhau and Abhiman Kolte authored Oct 17, 2024
1 parent ef34ada commit 5dbec8c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/cli/src/services/socket-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class SocketClient {
protocol: parsedProxyUrl.protocol,
}
if (parsedProxyUrl.username && parsedProxyUrl.password) {
proxy.proxyAuth = `${proxyUrlEnv.username}:${proxyUrlEnv.password}`
proxy.proxyAuth = `${parsedProxyUrl.username}:${parsedProxyUrl.password}`
}
if (isProxyHttps) {
options.wsOptions = {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/services/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export function assignProxy (baseURL: string, axiosConfig: CreateAxiosDefaults)
protocol: parsedProxyUrl.protocol,
}
if (parsedProxyUrl.username && parsedProxyUrl.password) {
proxy.proxyAuth = `${proxyUrlEnv.username}:${proxyUrlEnv.password}`
proxy.proxyAuth = `${parsedProxyUrl.username}:${parsedProxyUrl.password}`
}
if (isProxyHttps && isEndpointHttps) {
axiosConfig.httpsAgent = httpsOverHttps({ proxy })
Expand Down

0 comments on commit 5dbec8c

Please sign in to comment.