Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow strings to be passed as urls [gh-0] #807

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix: allow strings to be passed as urls [gh-0] #807

merged 2 commits into from
Jul 31, 2023

Conversation

umutuzgur
Copy link
Member

@umutuzgur umutuzgur commented Jul 31, 2023 •
edited
Loading

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Allow strings to be passed as urls. This is to handle handlebar templates in the string urls

@umutuzgur umutuzgur requested a review from clample July 31, 2023 07:48
@umutuzgur umutuzgur merged commit 8e5ac8c into main Jul 31, 2023
3 checks passed
@umutuzgur umutuzgur deleted the umutuzgur/gh-0/allow-strings-to-be-passed-as-urls branch July 31, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clample clample clample approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umutuzgur @clample