chore: handle 408 error and show message [gh-824] #825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
This PRs makes use of a response
axios
interceptor to catch408
errors and print a user-friendly message.I tried to add unit-tests for
axios
requests and interceptors here, but I had to__mocks__
axios resulting in issues with the e2e tests. That's why I moved the interceptors handler to separated functions to see if I couldspyOn
ormock
them (without success).TODO
: try to test interceptors. FYI, mockingaxios
worked to test request but it require some E2E tests adjustments.New Dependency Submission